pgsql: Remove gratuitous environment dependency in 002_types.pl test. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Remove gratuitous environment dependency in 002_types.pl test.
Date
Msg-id E1mW2bF-00008T-Fj@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove gratuitous environment dependency in 002_types.pl test.

Computing related timestamps by subtracting "N days" is sensitive
to the prevailing timezone, since we interpret that as "same local
time on the N'th prior day".  Even though the intervals in question
are only two to four days, through remarkable bad luck they managed
to cross the end of Ramadan in 2014, causing the test's output to
change if timezone is set to Africa/Casablanca.  (Maybe in other
Muslim areas as well; I didn't check.)  There's absolutely no reason
for this test to exercise interval subtraction, so just get rid of
that and use plain timestamptz constants representing the intended
values.

Per report from Andres Freund.  Back-patch to v10 where this test
script came in.

Discussion: https://postgr.es/m/20210930183641.7lh4jhvpipvromca@alap3.anarazel.de

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/afc6081f6ea8fa053dafe14e609d1d8e885410f8

Modified Files
--------------
src/test/subscription/t/002_types.pl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Treat ETIMEDOUT as indicating a non-recoverable connection failu
Next
From: David Rowley
Date:
Subject: pgsql: Ensure interleaved_parts field is always initialized