pgsql: Don't print extra parens around expressions in extended stats - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Don't print extra parens around expressions in extended stats
Date
Msg-id E1mLCwf-0006Nl-Vk@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't print extra parens around expressions in extended stats

The code printing expressions for extended statistics doubled the
parens, producing results like ((a+1)), which is unnecessary and not
consistent with how we print expressions elsewhere.

Fixed by tweaking the code to produce just a single set of parens.

Reported by Mark Dilger, fix by me. Backpatch to 14, where support for
extended statistics on expressions was added.

Reported-by: Mark Dilger
Discussion: https://postgr.es/m/20210122040101.GF27167%40telsasoft.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4d1816ec26e877297608a850736afed962527d70

Modified Files
--------------
src/backend/utils/adt/ruleutils.c               |   2 +-
src/bin/pg_dump/t/002_pg_dump.pl                |   2 +-
src/test/regress/expected/create_table_like.out |   6 +-
src/test/regress/expected/stats_ext.out         | 110 ++++++++++++------------
4 files changed, 60 insertions(+), 60 deletions(-)


pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: Remove unneeded old_rel_pages VACUUM state field.
Next
From: Tomas Vondra
Date:
Subject: pgsql: Don't print extra parens around expressions in extended stats