pgsql: Refresh apply delay on reload of recovery_min_apply_delay at rec - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Refresh apply delay on reload of recovery_min_apply_delay at rec
Date
Msg-id E1mFT3a-0002S5-HX@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Refresh apply delay on reload of recovery_min_apply_delay at recovery

This commit ensures that the wait interval in the replay delay loop
waiting for an amount of time defined by recovery_min_apply_delay is
correctly handled on reload, recalculating the delay if this GUC value
is updated, based on the timestamp of the commit record being replayed.

The previous behavior would be problematic for example with replay
still waiting even if the delay got reduced or just cancelled.  If the
apply delay was increased to a larger value, the wait would have just
respected the old value set, finishing earlier.

Author: Soumyadeep Chakraborty, Ashwin Agrawal
Reviewed-by: Kyotaro Horiguchi, Michael Paquier
Discussion: https://postgr.es/m/CAE-ML+93zfr-HLN8OuxF0BjpWJ17O5dv1eMvSE5jsj9jpnAXZA@mail.gmail.com
Backpatch-through: 9.6

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/024fd44e0566fe2db264aaa3c6d45d0dfdd30b60

Modified Files
--------------
src/backend/access/transam/xlog.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Un-break s_lock_test.
Next
From: Daniel Gustafsson
Date:
Subject: pgsql: Clarify initdb --sync-only help message and docs