pgsql: pgbench: When using pipelining only do PQconsumeInput() when nec - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: pgbench: When using pipelining only do PQconsumeInput() when nec
Date
Msg-id E1mBT3K-00014L-GG@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pgbench: When using pipelining only do PQconsumeInput() when necessary.

Up to now we did a PQconsumeInput() for each pipelined query, asking the OS
for more input - which it often won't have, as all results might already have
been sent. That turns out to have a noticeable performance impact.

Alvaro Herrera reviewed the idea to add the PQisBusy() check, but not this
concrete patch.

Author: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20210720180039.23rivhdft3l4mayn@alap3.anarazel.de
Backpatch: 14, where libpq/pgbench pipelining was introduced.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/87bff68840d542011ed8f60427502fb90fdf2873

Modified Files
--------------
src/bin/pgbench/pgbench.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: pgstat: split reporting/fetching of bgwriter and checkpointer st
Next
From: Andres Freund
Date:
Subject: pgsql: pgbench: When using pipelining only do PQconsumeInput() when nec