pgsql: Close yet another race condition in replication slot test code - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Close yet another race condition in replication slot test code
Date
Msg-id E1m9DJR-0000vv-Uu@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Close yet another race condition in replication slot test code  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Close yet another race condition in replication slot test code

Buildfarm shows that this test has a further failure mode when a
checkpoint starts earlier than expected, so we detect a "checkpoint
completed" line that's not the one we want.  Change the config to try
and prevent this.

Per buildfarm

While at it, update one comment that was forgotten in commit
d18e75664a2f.

Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20210729.162038.534808353849568395.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ce197e91d02ca38ac1b956a3e0c11596099e7893

Modified Files
--------------
src/backend/access/transam/xlog.c         |  2 +-
src/test/recovery/t/019_replslot_limit.pl | 14 ++++++++++++--
2 files changed, 13 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: docs: Fix bit_count example output
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Close yet another race condition in replication slot test code