pgsql: Make new replication slot test code less racy - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Make new replication slot test code less racy
Date
Msg-id E1m4oDz-00009Z-Or@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make new replication slot test code less racy

The new test code added in ead9e51e8236 is racy -- it hinges on
shared-memory state, which changes before the WARNING message is logged.
Put it the other way around.

Backpatch to 13.

Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m/202107161809.zclasccpfcg3@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8589299e03fff012e0bbb9716693750a0d68eef7

Modified Files
--------------
src/test/recovery/t/019_replslot_limit.pl | 27 +++++++++++++++------------
1 file changed, 15 insertions(+), 12 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Doc: document the current-transaction-modes GUCs.
Next
From: Dean Rasheed
Date:
Subject: pgsql: Improve error checking of CREATE COLLATION options.