pgsql: Robustify tuplesort's free_sort_tuple function - Mailing list pgsql-committers

From David Rowley
Subject pgsql: Robustify tuplesort's free_sort_tuple function
Date
Msg-id E1m37Hm-0006z8-Uw@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Robustify tuplesort's free_sort_tuple function

41469253e went to the trouble of removing a theoretical bug from
free_sort_tuple by checking if the tuple was NULL before freeing it. Let's
make this a little more robust by also setting the tuple to NULL so that
should we be called again we won't end up doing a pfree on the already
pfree'd tuple. Per advice from Tom Lane.

Discussion: https://postgr.es/m/3188192.1626136953@sss.pgh.pa.us
Backpatch-through: 9.6, same as 41469253e

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d0e44bae4923cebe08fd03f8ac6cb42757eec480

Modified Files
--------------
src/backend/utils/sort/tuplesort.c | 1 +
1 file changed, 1 insertion(+)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Robustify tuplesort's free_sort_tuple function
Next
From: David Rowley
Date:
Subject: pgsql: Remove useless range checks on INT8 sequences