pgsql: Ignore more environment variables in TAP tests - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Ignore more environment variables in TAP tests
Date
Msg-id E1lodTP-0003tN-VW@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Ignore more environment variables in TAP tests

Various environment variables were not getting reset in the TAP tests,
which would cause failures depending on the tests or the environment
variables involved.  For example, PGSSL{MAX,MIN}PROTOCOLVERSION could
cause failures in the SSL tests.  Even worse, a junk value of
PGCLIENTENCODING makes a server startup fail.  The list of variables
reset is adjusted in each stable branch depending on what is supported.

While on it, simplify a bit the code per a suggestion from Andrew
Dunstan, using a list of variables instead of doing single deletions.

Reviewed-by: Andrew Dunstan, Daniel Gustafsson
Discussion: https://postgr.es/m/YLbjjRpucIeZ78VQ@paquier.xyz
Backpatch-through: 9.6

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c63bb6950735103fa6528081014955d065c8ab64

Modified Files
--------------
src/test/perl/TestLib.pm | 36 ++++++++++++++++++++++++++----------
1 file changed, 26 insertions(+), 10 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Re-allow custom GUC names that have more than two components.
Next
From: David Rowley
Date:
Subject: pgsql: Standardize usages of appendStringInfo and appendPQExpBuffer