pgsql: Add fallback implementation for setenv() - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Add fallback implementation for setenv()
Date
Msg-id E1lnsH8-0001jL-AV@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add fallback implementation for setenv()

This fixes the code compilation on Windows with MSVC and Kerberos, as
a missing implementation of setenv() causes a compilation failure of the
GSSAPI code.  This was only reproducible when building the code with
Kerberos, something that buildfarm animal hamerkop has fixed recently.

This issue only happens on 12 and 13, as this code has been introduced
in b0b39f7.  HEAD is already able to compile properly thanks to
7ca37fb0, and this commit is a minimal cherry-pick of it.

Thanks to Tom Lane for the discussion.

Discussion: https://postgr.es/m/YLDtm5WGjPxm6ua4@paquier.xyz
Backpatch-through: 12

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/02037af3ff36d7a9023251c2fa4dc4efaa67bbf2

Modified Files
--------------
configure                     | 19 ++++++++++++++++-
configure.in                  |  4 +++-
src/include/pg_config.h.in    |  3 +++
src/include/pg_config.h.win32 |  3 +++
src/include/port.h            |  4 ++++
src/include/port/win32_port.h |  2 ++
src/port/setenv.c             | 48 +++++++++++++++++++++++++++++++++++++++++++
src/tools/msvc/Mkvcbuild.pm   |  2 +-
8 files changed, 82 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Fix error handling in replacement pthread_barrier_init().
Next
From: Amit Kapila
Date:
Subject: pgsql: pgoutput: Fix memory leak due to RelationSyncEntry.map.