pgsql: amcheck: MAXALIGN() nbtree special area offset. - Mailing list pgsql-committers

From Peter Geoghegan
Subject pgsql: amcheck: MAXALIGN() nbtree special area offset.
Date
Msg-id E1la4Ra-00081C-C7@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
amcheck:  MAXALIGN() nbtree special area offset.

This isn't strictly necessary, but in theory it might matter if in the
future the width of the nbtree special area changes -- its total size
might not be an even number of MAXALIGN() quantums, even with padding.
PageInit() MAXALIGN()s all special area offsets, but amcheck uses the
offset to perform initial basic validation of line pointers, so we don't
rely on the offset from the page header.

The real reason to do this is to set a good example for new code that
adds amcheck coverage for other index AMs.

Reported-By: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Discussion: https://postgr.es/m/CALj2ACUMqTR9nErh99FbOBmzCXE9=gXNqhBiwYOhejJJS1LXqQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bb3ecc8c961896ecb2ad3d5ba705c2877b933945

Modified Files
--------------
contrib/amcheck/verify_nbtree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Use correct format placeholder for WSAGetLastError()
Next
From: Michael Paquier
Date:
Subject: pgsql: Add some forgotten LSN_FORMAT_ARGS() in xlogreader.c