pgsql: Shut down transaction tracking at startup process exit. - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: Shut down transaction tracking at startup process exit.
Date
Msg-id E1lTT1e-0006cO-Og@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Shut down transaction tracking at startup process exit.

Maxim Orlov reported that the shutdown of standby server could result in
the following assertion failure. The cause of this issue was that,
when the shutdown caused the startup process to exit, recovery-time
transaction tracking was not shut down even if it's already initialized,
and some locks the tracked transactions were holding could not be released.
At this situation, if other process was invoked and the PGPROC entry that
the startup process used was assigned to it, it found such unreleased locks
and caused the assertion failure, during the initialization of it.

    TRAP: FailedAssertion("SHMQueueEmpty(&(MyProc->myProcLocks[i]))"

This commit fixes this issue by making the startup process shut down
transaction tracking and release all locks, at the exit of it.

Back-patch to all supported branches.

Reported-by: Maxim Orlov
Author: Fujii Masao
Reviewed-by: Maxim Orlov
Discussion: https://postgr.es/m/ad4ce692cc1d89a093b471ab1d969b0b@postgrespro.ru

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e7bcfd717ef31166617e0391d5c132f3cfb30fab

Modified Files
--------------
src/backend/postmaster/startup.c  | 19 +++++++++++++++++++
src/backend/storage/ipc/standby.c | 15 +++++++++++++++
2 files changed, 34 insertions(+)


pgsql-committers by date:

Previous
From: Fujii Masao
Date:
Subject: pgsql: Shut down transaction tracking at startup process exit.
Next
From: Fujii Masao
Date:
Subject: pgsql: Shut down transaction tracking at startup process exit.