pgsql: Fix order of parameters in BRIN minmax-multi calls - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Fix order of parameters in BRIN minmax-multi calls
Date
Msg-id E1lT6WE-00040P-4k@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix order of parameters in BRIN minmax-multi calls

The BRIN minmax-multi consistent function incorrectly assumed it can
lookup an operator, and then swap the arguments to get the commutator.
For example <(a,b) would be called as <(b,a) to get >(a,b). This works
when the arguments are of the same type, but with cross-type opclasses
this fails. We can't swap <(float4,float8) arguments, for example.

Fixed by passing arguments in the right order.

Discussion: https://postgr.es/m/CAJKUy5jLZFLCxyxfT%3DMfK5mtPfSzHA1rVLowR-j4RRsFVvKm7A%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1dad2a5ea3d14dd205603c31cc94ec088183ab2a

Modified Files
--------------
src/backend/access/brin/brin_minmax_multi.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: Fix BRIN minmax-multi distance for inet type
Next
From: Tomas Vondra
Date:
Subject: pgsql: Add regression test for minmax-multi macaddr8 type