pgsql: Revert b6002a796 - Mailing list pgsql-committers
| From | David Rowley |
|---|---|
| Subject | pgsql: Revert b6002a796 |
| Date | |
| Msg-id | E1lRlHL-0005Gj-Gf@gemulon.postgresql.org Whole thread Raw |
| List | pgsql-committers |
Revert b6002a796 This removes "Add Result Cache executor node". It seems that something weird is going on with the tracking of cache hits and misses as highlighted by many buildfarm animals. It's not yet clear what the problem is as other parts of the plan indicate that the cache did work correctly, it's just the hits and misses that were being reported as 0. This is especially a bad time to have the buildfarm so broken, so reverting before too many more animals go red. Discussion: https://postgr.es/m/CAApHDvq_hydhfovm4=izgWs+C5HqEeRScjMbOgbpC-jRAeK3Yw@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/28b3e3905c982c42fb10ee800e6f881e9742c89d Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 25 +- contrib/postgres_fdw/sql/postgres_fdw.sql | 2 - doc/src/sgml/config.sgml | 24 +- src/backend/commands/explain.c | 140 --- src/backend/executor/Makefile | 1 - src/backend/executor/execAmi.c | 5 - src/backend/executor/execExpr.c | 134 --- src/backend/executor/execParallel.c | 18 - src/backend/executor/execProcnode.c | 10 - src/backend/executor/nodeResultCache.c | 1137 ------------------------ src/backend/nodes/copyfuncs.c | 31 - src/backend/nodes/outfuncs.c | 37 - src/backend/nodes/readfuncs.c | 22 - src/backend/optimizer/path/allpaths.c | 4 - src/backend/optimizer/path/costsize.c | 148 --- src/backend/optimizer/path/joinpath.c | 214 ----- src/backend/optimizer/plan/createplan.c | 87 -- src/backend/optimizer/plan/initsplan.c | 41 - src/backend/optimizer/plan/setrefs.c | 9 - src/backend/optimizer/plan/subselect.c | 5 - src/backend/optimizer/util/pathnode.c | 71 -- src/backend/optimizer/util/restrictinfo.c | 3 - src/backend/utils/misc/guc.c | 10 - src/backend/utils/misc/postgresql.conf.sample | 1 - src/include/executor/executor.h | 7 - src/include/executor/nodeResultCache.h | 31 - src/include/lib/ilist.h | 19 - src/include/nodes/execnodes.h | 66 -- src/include/nodes/nodes.h | 3 - src/include/nodes/pathnodes.h | 22 - src/include/nodes/plannodes.h | 21 - src/include/optimizer/cost.h | 1 - src/include/optimizer/pathnode.h | 7 - src/test/regress/expected/aggregates.out | 2 - src/test/regress/expected/join.out | 131 ++- src/test/regress/expected/partition_prune.out | 243 +++-- src/test/regress/expected/resultcache.out | 159 ---- src/test/regress/expected/subselect.out | 20 +- src/test/regress/expected/sysviews.out | 3 +- src/test/regress/parallel_schedule | 2 +- src/test/regress/serial_schedule | 1 - src/test/regress/sql/aggregates.sql | 2 - src/test/regress/sql/join.sql | 2 - src/test/regress/sql/partition_prune.sql | 3 - src/test/regress/sql/resultcache.sql | 85 -- 45 files changed, 186 insertions(+), 2823 deletions(-)
pgsql-committers by date: