pgsql: Fix portability and safety issues in pqTraceFormatTimestamp. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix portability and safety issues in pqTraceFormatTimestamp.
Date
Msg-id E1lRi0O-0003vA-Df@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix portability and safety issues in pqTraceFormatTimestamp.

Remove confusion between time_t and pg_time_t; neither
gettimeofday() nor localtime() deal in the latter.
libpq indeed has no business using <pgtime.h> at all.

Use snprintf not sprintf, to ensure we can't overrun the
supplied buffer.  (Unlikely, but let's be safe.)

Per buildfarm.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f1be740a991406d7885047beb971e1ff5dbe8b71

Modified Files
--------------
src/interfaces/libpq/fe-trace.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Don't prematurely cram a value into a short int.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix unportable use of isprint().