pgsql: Use lfirst_int in cmp_list_len_contents_asc - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Use lfirst_int in cmp_list_len_contents_asc
Date
Msg-id E1lNOCS-0000wd-7c@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Use lfirst_int in cmp_list_len_contents_asc

The function added in be45be9c33 is comparing integer lists (IntList) by
length and contents, but there were two bugs.  Firstly, it used intVal()
to extract the value, but that's for Value nodes, not for extracting int
values from IntList.  Secondly, it called it directly on the ListCell,
without doing lfirst().  So just do lfirst_int() instead.

Interestingly enough, this did not cause any crashes on the buildfarm,
but valgrind rightfully complained about it.

Discussion: https://postgr.es/m/bf3805a8-d7d1-ae61-fece-761b7ff41ecc@postgresfriends.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b822ae13ea93c18326d58d47829bbc66d36fae5c

Modified Files
--------------
src/backend/parser/parse_agg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Fix use-after-ReleaseSysCache problem in ATExecAlterColumnType.
Next
From: Thomas Munro
Date:
Subject: pgsql: Provide recovery_init_sync_method=syncfs.