pgsql: Prevent buffer overrun in read_tablespace_map(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Prevent buffer overrun in read_tablespace_map().
Date
Msg-id E1lMcdD-0007vp-Nx@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Prevent buffer overrun in read_tablespace_map().

Robert Foggia of Trustwave reported that read_tablespace_map()
fails to prevent an overrun of its on-stack input buffer.
Since the tablespace map file is presumed trustworthy, this does
not seem like an interesting security vulnerability, but still
we should fix it just in the name of robustness.

While here, document that pg_basebackup's --tablespace-mapping option
doesn't work with tar-format output, because it doesn't.  To make it
work, we'd have to modify the tablespace_map file within the tarball
sent by the server, which might be possible but I'm not volunteering.
(Less-painful solutions would require changing the basebackup protocol
so that the source server could adjust the map.  That's not very
appetizing either.)

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/19b32bd53f90577a130879ddfeb4f9d75d08c1c5

Modified Files
--------------
doc/src/sgml/ref/pg_basebackup.sgml | 10 ++++++++--
src/backend/access/transam/xlog.c   |  2 +-
2 files changed, 9 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Doc: improve discussion of variable substitution in PL/pgSQL.
Next
From: Tom Lane
Date:
Subject: pgsql: Doc: remove duplicated step in RLS example.