pgsql: Don't add bailout adjustment for non-strict deserialize calls. - Mailing list pgsql-committers

From Andrew Gierth
Subject pgsql: Don't add bailout adjustment for non-strict deserialize calls.
Date
Msg-id E1l55ab-0004nx-Li@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't add bailout adjustment for non-strict deserialize calls.

When building aggregate expression steps, strict checks need a bailout
jump for when a null value is encountered, so there is a list of steps
that require later adjustment. Adding entries to that list for steps
that aren't actually strict would be harmless, except that there is an
Assert which catches them. This leads to spurious errors on asserts
builds, for data sets that trigger parallel aggregation of an
aggregate with a non-strict deserialization function (no such
aggregates exist in the core system).

Repair by not adding the adjustment entry when it's not needed.

Backpatch back to 11 where the code was introduced.

Per a report from Darafei (Komzpa) of the PostGIS project; analysis
and patch by me.

Discussion: https://postgr.es/m/87mty7peb3.fsf@news-spur.riddles.org.uk

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/75e3cca42d6f1121934d982a9f9efd37226e875d

Modified Files
--------------
src/backend/executor/execExpr.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix crash of pg_stat_statements_info() without library loaded
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Add mbverifystr() functions specific to each encoding.