Disable vacuum page skipping in selected test cases.
By default VACUUM will skip pages that it can't immediately get
exclusive access to, which means that even activities as harmless
and unpredictable as checkpoint buffer writes might prevent a page
from being processed. Ordinarily this is no big deal, but we have
a small number of test cases that examine the results of VACUUM's
processing and therefore will fail if the page of interest is skipped.
This seems to be the explanation for some rare buildfarm failures.
To fix, add the DISABLE_PAGE_SKIPPING option to the VACUUM commands
in tests where this could be an issue.
In passing, remove a duplicated query in pageinspect/sql/page.sql.
Back-patch as necessary (some of these cases are as old as v10).
Discussion: https://postgr.es/m/413923.1611006484@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c2dc1a79767a0f947e1145f82eb65dfe4360d25f
Modified Files
--------------
contrib/amcheck/expected/check_heap.out | 2 +-
contrib/amcheck/sql/check_heap.sql | 2 +-
contrib/amcheck/t/001_verify_heapam.pl | 2 +-
contrib/pageinspect/expected/page.out | 16 +++-------------
contrib/pageinspect/sql/page.sql | 12 +++---------
contrib/pg_visibility/expected/pg_visibility.out | 6 +++---
contrib/pg_visibility/sql/pg_visibility.sql | 6 +++---
7 files changed, 15 insertions(+), 31 deletions(-)
