pgsql: Disallow CREATE STATISTICS on system catalogs - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Disallow CREATE STATISTICS on system catalogs
Date
Msg-id E1l0Xkl-0002UV-Ki@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Disallow CREATE STATISTICS on system catalogs

Add a check that CREATE STATISTICS does not add extended statistics on
system catalogs, similarly to indexes etc.  It can be overriden using
the allow_system_table_mods GUC.

This bug exists since 7b504eb282c, adding the extended statistics, so
backpatch all the way back to PostgreSQL 10.

Author: Tomas Vondra
Reported-by: Dean Rasheed
Backpatch-through: 10
Discussion: https://postgr.es/m/CAEZATCXAPrrOKwEsyZKQ4uzzJQWBCt6QAvOcgqRGdWwT1zb%2BrQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c9a0dc34865f2f82d8e186f534d9b605afaa4d11

Modified Files
--------------
src/backend/commands/statscmds.c        |  7 +++++++
src/test/regress/expected/stats_ext.out | 12 +++++++-----
src/test/regress/sql/stats_ext.sql      | 12 +++++++-----
3 files changed, 21 insertions(+), 10 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Improve our heuristic for selecting PG_SYSROOT on macOS.
Next
From: Tomas Vondra
Date:
Subject: pgsql: Disallow CREATE STATISTICS on system catalogs