pgsql: Further second thoughts about idle_session_timeout patch. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Further second thoughts about idle_session_timeout patch.
Date
Msg-id E1kxYPy-0002OX-V0@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Further second thoughts about idle_session_timeout patch.

On reflection, the order of operations in PostgresMain() is wrong.
These timeouts ought to be shut down before, not after, we do the
post-command-read CHECK_FOR_INTERRUPTS, to guarantee that any
timeout error will be detected there rather than at some ill-defined
later point (possibly after having wasted a lot of work).

This is really an error in the original idle_in_transaction_timeout
patch, so back-patch to 9.6 where that was introduced.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b8d0cda53377515ac61357ec4a60e85ca873f486

Modified Files
--------------
src/backend/tcop/postgres.c | 31 ++++++++++++++++---------------
1 file changed, 16 insertions(+), 15 deletions(-)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: Minor fixes in COPY progress docs
Next
From: Tom Lane
Date:
Subject: pgsql: Further second thoughts about idle_session_timeout patch.