pgsql: Disallow SRFs when considering sorts below Gather Merge - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Disallow SRFs when considering sorts below Gather Merge
Date
Msg-id E1krQ2o-0005jp-BM@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Disallow SRFs when considering sorts below Gather Merge

While we do allow SRFs in ORDER BY, scan/join processing should not
consider such cases - such sorts should only happen via final Sort atop
a ProjectSet. So make sure we don't try adding such sorts below Gather
Merge, just like we do for expressions that are volatile and/or not
parallel safe.

Backpatch to PostgreSQL 13, where this code was introduced as part of
the Incremental Sort patch.

Author: James Coleman
Reviewed-by: Tomas Vondra
Backpatch-through: 13
Discussion: https://postgr.es/m/CAAaqYe8cK3g5CfLC4w7bs=hC0mSksZC=H5M8LSchj5e5OxpTAg@mail.gmail.com
Discussion: https://postgr.es/m/295524.1606246314%40sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fac1b470a9f7e846534620b78ea4cf122ed432b2

Modified Files
--------------
src/backend/optimizer/path/equivclass.c        |  7 +++++++
src/backend/optimizer/util/tlist.c             |  5 -----
src/include/optimizer/optimizer.h              |  5 +++++
src/test/regress/expected/incremental_sort.out | 12 ++++++++++++
src/test/regress/sql/incremental_sort.sql      |  2 ++
5 files changed, 26 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Remove "invalid concatenation of jsonb objects" error case.
Next
From: Tomas Vondra
Date:
Subject: pgsql: Disallow SRFs when considering sorts below Gather Merge