pgsql: jit: Correct parameter type for generated expression evaluation - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: jit: Correct parameter type for generated expression evaluation
Date
Msg-id E1kmTlV-0004Yg-Jt@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
jit: Correct parameter type for generated expression evaluation functions.

clang only uses the 'i1' type for scalar booleans, not for pointers to
booleans (as the pointer might be pointing into a larger memory
allocation). Therefore a pointer-to-bool needs to the "storage" boolean.

There's no known case of wrong code generation due to this, but it seems quite
possible that it could cause problems (see e.g. 72559438f92).

Author: Andres Freund
Discussion: https://postgr.es/m/20201207212142.wz5tnbk2jsaqzogb@alap3.anarazel.de
Backpatch: 11-, where jit support was added

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1e16ad101459432418d61a0faf2c7692ad76459b

Modified Files
--------------
src/backend/jit/llvm/llvmjit_expr.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: jit: Correct parameter type for generated expression evaluation
Next
From: Andres Freund
Date:
Subject: pgsql: jit: configure: Explicitly reference 'native' component.