pgsql: jit: Correct parameter type for generated expression evaluation - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: jit: Correct parameter type for generated expression evaluation
Date
Msg-id E1kmTlL-0004XD-Dn@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
jit: Correct parameter type for generated expression evaluation functions.

clang only uses the 'i1' type for scalar booleans, not for pointers to
booleans (as the pointer might be pointing into a larger memory
allocation). Therefore a pointer-to-bool needs to the "storage" boolean.

There's no known case of wrong code generation due to this, but it seems quite
possible that it could cause problems (see e.g. 72559438f92).

Author: Andres Freund
Discussion: https://postgr.es/m/20201207212142.wz5tnbk2jsaqzogb@alap3.anarazel.de
Backpatch: 11-, where jit support was added

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/01c6370a32e5875a63400c6e465de775a51ef1b8

Modified Files
--------------
src/backend/jit/llvm/llvmjit_expr.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Avoid using tuple from syscache for update of pg_database.datfro
Next
From: Andres Freund
Date:
Subject: pgsql: jit: Correct parameter type for generated expression evaluation