pgsql: Make some sanity-check elogs more verbose - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Make some sanity-check elogs more verbose
Date
Msg-id E1khEQS-0003tM-5Q@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make some sanity-check elogs more verbose

A few sanity checks in funcapi.c were not mentioning all the possible
clauses for failure, confusing developers who fat-fingered catalog data
additions.  Make the errors more detailed to avoid wasting time in
pinpointing mistakes.

Per complaint from Craig Ringer.
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAMsr+YH7Kd87A3cU5m_wKo46HPQ46zFv5wesFNL0YWxkGhGv3g@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fe051291550ab88267ce3104e9833925bf757393

Modified Files
--------------
src/backend/utils/fmgr/funcapi.c | 25 +++++++++++++++----------
1 file changed, 15 insertions(+), 10 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix a few comments that referred to copy.c.
Next
From: Tom Lane
Date:
Subject: pgsql: Improve wording of two error messages related to generated colum