pgsql: Fix checksum calculation in the new sorting GiST build. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Fix checksum calculation in the new sorting GiST build.
Date
Msg-id E1kKKS4-0006Gy-Bd@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix checksum calculation in the new sorting GiST build.

Since we're bypassing the buffer manager, we need to call
PageSetChecksumInplace() directly. As reported by Justin Pryzby.

In the passing, add RelationOpenSmgr() calls before all smgrwrite() and
smgrextend() calls. Tom added one before the first smgrextend() call in
commit c2bb287025, which seems to be enough, but let's play it safe and
do it before each one. That's how it's done in the similar code in
nbtsort.c, too.

Discussion: https://www.postgresql.org/message-id/20200920224446.GF30557@telsasoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c47a240fe6db8293e2de1565233faee40afa64b6

Modified Files
--------------
src/backend/access/gist/gistbuild.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Translation updates
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Standardize order of use strict and use warnings in Perl code