pgsql: pg_surgery: Try to stabilize regression tests. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: pg_surgery: Try to stabilize regression tests.
Date
Msg-id E1kJKA6-00072w-HO@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: pg_surgery: Try to stabilize regression tests.
List pgsql-committers
pg_surgery: Try to stabilize regression tests.

According to buildfarm member sungazer, the behavior of VACUUM can be
unstable in these tests even if we prevent autovacuum from running on
the tables in question, apparently because even a manual vacuum can
behave differently depending on whether anything else is running that
holds back the global xmin. So use a temporary table instead, which
as of commit a7212be8b9e0885ee769e8c55f99ef742cda487b enables
vacuuming using a more aggressive cutoff.

This approach can't be used for the regression test that involves a
materialized view, but that test doesn't run vacuum, so it shouldn't
be prone to this particular failure mode.

Analysis by Tom Lane. Patch by Ashutosh Sharma and me.

Discussion: http://postgr.es/m/665524.1599948007@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0811f766fd740018a72e222521553f8b22e7b3d6

Modified Files
--------------
contrib/pg_surgery/expected/heap_surgery.out | 10 ++++------
contrib/pg_surgery/sql/heap_surgery.sql      | 11 ++++-------
2 files changed, 8 insertions(+), 13 deletions(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Update file header comments for logical/relation.c.
Next
From: Tom Lane
Date:
Subject: pgsql: Allow most keywords to be used as column labels without requirin