pgsql: Fix over-eager ping'ing in logical replication receiver. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix over-eager ping'ing in logical replication receiver.
Date
Msg-id E1kEM9O-0004EI-RL@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix over-eager ping'ing in logical replication receiver.

Commit 3f60f690f only partially fixed the broken-status-tracking
issue in LogicalRepApplyLoop: we need ping_sent to have the same
lifetime as last_recv_timestamp.  The effects are much less serious
than what that commit fixed, though.  AFAICS this would just lead to
extra ping requests being sent, once per second until the sender
responds.  Still, it's a bug, so backpatch to v10 as before.

Discussion: https://postgr.es/m/959627.1599248476@sss.pgh.pa.us

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9b8a8516ed2e4268026a826c5e9b768f88aa67aa

Modified Files
--------------
src/backend/replication/logical/worker.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Jeff Davis
Date:
Subject: pgsql: Fix bogus MaxAllocSize check in logtape.c.
Next
From: Tom Lane
Date:
Subject: pgsql: Make new authentication test case more robust.