Fixed following SonarQube issues:
- Remove this assignment to the local variable, the value is never used.
- Rename local variables to match the regular expression
- Add logic to this except clause or eliminate it and rethrow the exception automatically.
- Rename fields to match the regular expression
- Extract this nested conditional expression into an independent statement.
- Change this default value to "None" and initialize this parameter inside the function/method.
- Update this function so that its implementation is not identical to __repr__
- Refactor this method to not always return the same value
- Reraise this exception to stop the application as the user expects
- Add missing parameters _w _PY3. This method overrides simplejson.decoder.JSONDecoder.decode.
- Remove this redundant continue.
- Remove this unused function declaration
- Remove this identity check; it will always be False.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=536593bf8a2e734a96d67f27b5a330d592c28d8f
Author: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Modified Files
--------------
tools/dependency_inventory.py | 1 -
.../browser/server_groups/servers/__init__.py | 8 +++--
.../server_groups/servers/databases/__init__.py | 2 --
.../databases/schemas/foreign_tables/__init__.py | 9 +++--
.../schemas/tables/partitions/__init__.py | 2 +-
.../servers/databases/schemas/types/__init__.py | 14 ++++----
web/pgadmin/misc/bgprocess/processes.py | 21 +----------
web/pgadmin/misc/file_manager/__init__.py | 41 +++++++++++-----------
web/pgadmin/tools/debugger/__init__.py | 6 ++--
web/pgadmin/tools/schema_diff/directory_compare.py | 3 +-
web/pgadmin/tools/sqleditor/__init__.py | 5 +--
.../tools/sqleditor/utils/start_running_query.py | 5 +--
web/pgadmin/utils/ajax.py | 2 +-
web/pgadmin/utils/csv.py | 6 ++--
web/pgadmin/utils/driver/psycopg2/connection.py | 39 +++++---------------
.../utils/driver/psycopg2/server_manager.py | 7 ++--
web/pgadmin/utils/session.py | 8 ++---
web/regression/python_test_utils/test_utils.py | 6 ++--
web/regression/runtests.py | 2 ++
19 files changed, 74 insertions(+), 113 deletions(-)
