pgsql: Fix removal of files generated by TAP tests for SSL - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Fix removal of files generated by TAP tests for SSL
Date
Msg-id E1jqRs1-0004kp-2T@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix removal of files generated by TAP tests for SSL

001_ssltests.pl and 002_scram.pl both generated an extra file for a
client key used in the tests that were not removed.  In Debian, this
causes repeated builds to fail.

The code refactoring done in 4dc6355 broke the cleanup done in
001_ssltests.pl, and the new tests added in 002_scram.pl via d6e612f
forgot the removal of one file.  While on it, fix a second issue
introduced in 002_scram.pl where we use the same file name in 001 and
002 for the temporary client key whose permissions are changed in the
test, as using the same file name in both tests could cause failures
with parallel jobs of src/test/ssl/ if one test removes a file still
needed by the second test.

Reported-by: Felix Lechner
Author: Daniel Gustafsson, Felix Lechner
Reviewed-by: Tom Lane, Michael Paquier
Discussion: https://postgr.es/m/CAFHYt543sjX=Cm_aEeoejStyP47C+Y3+Wh6WbirLXsgUMaw7iw@mail.gmail.com
Backpatch-through: 13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c4342c932abb6792f6c7d8528b6224ca4d5e1a84

Modified Files
--------------
src/test/ssl/t/001_ssltests.pl |  4 +++-
src/test/ssl/t/002_scram.pl    | 16 +++++++++++-----
2 files changed, 14 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Further adjustments to Hashagg EXPLAIN ANALYZE output
Next
From: Michael Paquier
Date:
Subject: pgsql: Refactor creation of normal dependency records when creating ext