pgsql: Ensure write failure reports no-disk-space - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Ensure write failure reports no-disk-space
Date
Msg-id E1jmOXK-0008SX-Nr@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Ensure write failure reports no-disk-space

A few places calling fwrite and gzwrite were not setting errno to ENOSPC
when reporting errors, as is customary; this led to some failures being
reported as
"could not write file: Success"
which makes us look silly.  Make a few of these places in pg_dump and
pg_basebackup use our customary pattern.

Backpatch-to: 9.5
Author: Justin Pryzby <pryzby@telsasoft.com>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m/20200611153753.GU14879@telsasoft.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2e155d90d1b867f7b5bf9616236386eb1e0f40ff

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c | 12 ++++++++++++
src/bin/pg_dump/pg_backup_directory.c | 19 ++++++++++++++++++-
2 files changed, 30 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Future-proof regression tests against possibly-missing posixrule
Next
From: Amit Kapila
Date:
Subject: pgsql: Removal unused function parameter in CopyReadBinaryAttribute.