pgsql: Fix the MSVC build for versions 2015 and later. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Fix the MSVC build for versions 2015 and later.
Date
Msg-id E1jZ5UY-000867-MW@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix the MSVC build for versions 2015 and later.

Visual Studio 2015 and later versions should still be able to do the same
as Visual Studio 2012, but the declaration of locale_name is missing in
_locale_t, causing the code compilation to fail, hence this falls back
instead on to enumerating all system locales by using EnumSystemLocalesEx
to find the required locale name.  If the input argument is in Unix-style
then we can get ISO Locale name directly by using GetLocaleInfoEx() with
LCType as LOCALE_SNAME.

In passing, change the documentation references of the now obsolete links.

Note that this problem occurs only with NLS enabled builds.

Author: Juan José Santamaría Flecha, Davinder Singh and Amit Kapila
Reviewed-by: Ranier Vilela and Amit Kapila
Backpatch-through: 9.5
Discussion: https://postgr.es/m/CAHzhFSFoJEWezR96um4-rg5W6m2Rj9Ud2CNZvV4NWc9tXV7aXQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a169155453e3d1c40c729a5318fd5298a990e5b0

Modified Files
--------------
src/backend/utils/adt/pg_locale.c | 236 ++++++++++++++++++++++++++++++++------
1 file changed, 203 insertions(+), 33 deletions(-)


pgsql-committers by date:

Previous
From: Noah Misch
Date:
Subject: pgsql: Fix pg_recvlogical avoidance of superfluous Standby Status Updat
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Move check for fsync=off so that pendingOps still gets cleared.