pgsql: Rework EXPLAIN format for incremental sort - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Rework EXPLAIN format for incremental sort
Date
Msg-id E1jYZSf-0003EM-0n@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Rework EXPLAIN format for incremental sort

The explain format used by incremental sort was somewhat inconsistent
with other nodes, making it harder to parse and understand. This commit
addresses that by

 - adding an extra space to better separate groups of values

 - using colons instead of equal signs to separate key/value

 - properly capitalizing first letter of a key

 - using separate lines for full and pre-sorted groups

These changes were proposed by Justin Pryzby and mostly copy the final
explain format used to report WAL usage.

Author: Justin Pryzby
Reviewed-by: James Coleman
Discussion: https://postgr.es/m/20200419023625.GP26953@telsasoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6a918c3ac8a6b1d8b53cead6fcb7cbd84eee5750

Modified Files
--------------
src/backend/commands/explain.c                 | 21 +++++++++------------
src/test/regress/expected/incremental_sort.out | 21 +++++++++++----------
src/test/regress/sql/incremental_sort.sql      |  4 ++--
3 files changed, 22 insertions(+), 24 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Do pre-release housekeeping on catalog data.
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Add -Wimplicit-fallthrough to CFLAGS and CXXFLAGS