pgsql: Fix minor memory leak in pg_basebackup and pg_receivewal - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Fix minor memory leak in pg_basebackup and pg_receivewal
Date
Msg-id E1jPG65-0003rj-Bq@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix minor memory leak in pg_basebackup and pg_receivewal

The result of the query used to retrieve the WAL segment size from the
backend was not getting freed in two code paths.  Both pg_basebackup and
pg_receivewal exit immediately if a failure happened on this query, so
this was not an actual problem, but it could be an issue if this code
gets used for other tools in different ways, be they future tools in
this code tree or external, existing, ones.

Oversight in commit fc49e24, so backpatch down to 11.

Author: Jie Zhang
Discussion: https://postgr.es/m/970ad9508461469b9450b64027842331@G08CNEXMBPEKD06.g08.fujitsu.local
Backpatch-through: 11

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/198efe774b0d2065d828cf7822376a2871c671fc

Modified Files
--------------
src/bin/pg_basebackup/streamutil.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Remove unneeded constraint dependency tracking
Next
From: Noah Misch
Date:
Subject: Re: pgsql: When WalSndCaughtUp, sleep only in WalSndWaitForWal().