pgsql: Code review for backup manifest. - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: Code review for backup manifest.
Date
Msg-id E1jOXar-0003r2-RQ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Code review for backup manifest.

This commit prevents pg_basebackup from receiving backup_manifest file
when --no-manifest is specified. Previously, when pg_basebackup was
writing a tarfile to stdout, it tried to receive backup_manifest file even
when --no-manifest was specified, and reported an error.

Also remove unused -m option from pg_basebackup.

Also fix typo in BASE_BACKUP command documentation.

Author: Fujii Masao
Reviewed-by: Michael Paquier, Robert Haas
Discussion: https://postgr.es/m/01e3ed3a-8729-5aaa-ca84-e60e3ca59db8@oss.nttdata.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a2ac73e7be7adf2a9248d14322d3a5e055ea4fd0

Modified Files
--------------
doc/src/sgml/protocol.sgml            | 10 +++++-----
src/bin/pg_basebackup/pg_basebackup.c |  4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: Remove obsolete "hole in center of page" comment.
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix minor memory leak in pg_dump