pgsql: Adjust bytea get_bit/set_bit to cope with bytea strings > 256MB. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Adjust bytea get_bit/set_bit to cope with bytea strings > 256MB.
Date
Msg-id E1jLusY-0000y1-9f@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Adjust bytea get_bit/set_bit to cope with bytea strings > 256MB.

Since the existing bit number argument can't exceed INT32_MAX, it's
not possible for these functions to manipulate bits beyond the first
256MB of a bytea value.  However, it'd be good if they could do at
least that much, and not fall over entirely for longer bytea values.
Adjust the comparisons to be done in int64 arithmetic so that works.
Also tweak the error reports to show sane values in case of overflow.

Also add some test cases to improve the miserable code coverage
of these functions.

Apply patch to back branches only; HEAD has a better solution
as of commit 26a944cf2.

Extracted from a much larger patch by Movead Li

Discussion: https://postgr.es/m/20200312115135445367128@highgo.ca

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e40c4d4914fd7e4682ae96ba8b772c96ec5b9414

Modified Files
--------------
src/backend/utils/adt/varlena.c       | 10 +++--
src/test/regress/expected/strings.out | 78 +++++++++++++++++++++++++++++++++++
src/test/regress/sql/strings.sql      | 26 ++++++++++++
3 files changed, 110 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Support FETCH FIRST WITH TIES
Next
From: Alexander Korotkov
Date:
Subject: pgsql: Implement waiting for given lsn at transaction start