pgsql: Drop slot's LWLock before returning from SaveSlotToPath() - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Drop slot's LWLock before returning from SaveSlotToPath()
Date
Msg-id E1jHSMb-00087J-4W@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Drop slot's LWLock before returning from SaveSlotToPath()

When SaveSlotToPath() is called with elevel=LOG, the early exits didn't
release the slot's io_in_progress_lock.

This could result in a walsender being stuck on the lock forever.  A
possible way to get into this situation is if the offending code paths
are triggered in a low disk space situation.

Author: Pavan Deolasee <pavan.deolasee@2ndquadrant.com>
Reported-by: Craig Ringer <craig@2ndquadrant.com>
Discussion: https://www.postgresql.org/message-id/flat/56a138c5-de61-f553-7e8f-6789296de785%402ndquadrant.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/223e9c77dcaf8788fdca2fab3a3b65b797a54615

Modified Files
--------------
src/backend/replication/slot.c | 10 ++++++++++
1 file changed, 10 insertions(+)


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Provide a TLS init hook
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Provide a TLS init hook