pgsql: pg_upgrade: make get_major_server_version() err msg consistent - Mailing list pgsql-committers

From Bruce Momjian
Subject pgsql: pg_upgrade: make get_major_server_version() err msg consistent
Date
Msg-id E1jF0j1-0001aL-IU@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_upgrade:  make get_major_server_version() err msg consistent

This patch fixes the error message in get_major_server_version() to be
"could not parse version file", and uses the full file path name, rather
than just the data directory path.

Also, commit 4109bb5de4 added the cause of the failure to the  "could
not open" error message, and improved quoting.  This patch backpatches
the "could not open" cause to PG 12, where it was first widely used, and
backpatches the quoting fix in that patch to all supported releases.

Reported-by: Tom Lane

Discussion: https://postgr.es/m/87pne2w98h.fsf@wibble.ilmari.org

Author: Dagfinn Ilmari Mannsåker

Backpatch-through: 9.5

Branch
------
REL9_5_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2c9864e5160672274c3e94c37cfaee5cab125cbf

Modified Files
--------------
src/bin/pg_upgrade/server.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Alexander Korotkov
Date:
Subject: pgsql: Add new typedefs introduced in 773df883e8 to typedefs.list
Next
From: Jeff Davis
Date:
Subject: pgsql: Revert "Specialize MemoryContextMemAllocated()."