pgsql: Remove overzealous _bt_split() assertions. - Mailing list pgsql-committers

Remove overzealous _bt_split() assertions.

_bt_split() is passed NULL as its insertion scankey for internal page
splits.  Two recently added Assert() statements failed to consider this,
leading to a crash with pg_upgrade'd BREE_VERSION < 4 indexes.  Remove
the assertions.

The assertions in question were added by commit 0d861bbb, which added
nbtree deduplication.  It would be possible to fix the assertions
directly instead, but they weren't adding much anyway.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1e07f5e0a1cf56f8cbc121dbb86c128a0f711c94

Modified Files
--------------
src/backend/access/nbtree/nbtinsert.c | 2 --
1 file changed, 2 deletions(-)