pgsql: Clean up newlines following left parentheses - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Clean up newlines following left parentheses
Date
Msg-id E1ixD6K-0008I3-GD@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Clean up newlines following left parentheses

We used to strategically place newlines after some function call left
parentheses to make pgindent move the argument list a few chars to the
left, so that the whole line would fit under 80 chars.  However,
pgindent no longer does that, so the newlines just made the code
vertically longer for no reason.  Remove those newlines, and reflow some
of those lines for some extra naturality.

Reviewed-by: Michael Paquier, Tom Lane
Discussion: https://postgr.es/m/20200129200401.GA6303@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c9d29775195922136c09cc980bb1b7091bf3d859

Modified Files
--------------
contrib/btree_gin/btree_gin.c                   |  6 +--
contrib/btree_gist/btree_cash.c                 | 17 +++----
contrib/btree_gist/btree_date.c                 | 63 ++++++++++++-------------
contrib/btree_gist/btree_enum.c                 | 48 +++++++++----------
contrib/btree_gist/btree_float4.c               | 17 +++----
contrib/btree_gist/btree_float8.c               | 17 +++----
contrib/btree_gist/btree_inet.c                 |  6 +--
contrib/btree_gist/btree_int2.c                 | 16 +++----
contrib/btree_gist/btree_int4.c                 | 16 +++----
contrib/btree_gist/btree_int8.c                 | 16 +++----
contrib/btree_gist/btree_interval.c             | 16 +++----
contrib/btree_gist/btree_macaddr.c              | 11 ++---
contrib/btree_gist/btree_macaddr8.c             | 11 ++---
contrib/btree_gist/btree_numeric.c              | 24 ++++------
contrib/btree_gist/btree_oid.c                  | 16 +++----
contrib/btree_gist/btree_time.c                 | 30 +++++-------
contrib/btree_gist/btree_ts.c                   | 26 ++++------
contrib/btree_gist/btree_utils_var.c            |  7 ++-
contrib/btree_gist/btree_uuid.c                 | 13 ++---
contrib/cube/cube.c                             | 24 ++++------
contrib/dblink/dblink.c                         |  6 +--
contrib/fuzzystrmatch/dmetaphone.c              | 18 +++----
contrib/hstore/hstore_op.c                      |  6 +--
contrib/intarray/_int_op.c                      |  8 +---
contrib/ltree/_ltree_gist.c                     |  6 +--
contrib/ltree/lquery_op.c                       | 13 ++---
contrib/ltree/ltree_gist.c                      | 18 +++----
contrib/ltree/ltxtquery_op.c                    | 13 ++---
contrib/oid2name/oid2name.c                     |  3 +-
contrib/pageinspect/heapfuncs.c                 |  3 +-
contrib/pg_trgm/trgm_gist.c                     | 12 ++---
contrib/pg_trgm/trgm_op.c                       |  6 +--
contrib/seg/seg.c                               | 30 +++++++-----
contrib/test_decoding/test_decoding.c           |  4 +-
src/backend/access/gin/ginlogic.c               |  6 +--
src/backend/access/gist/gistproc.c              | 12 ++---
src/backend/access/heap/heapam.c                |  3 +-
src/backend/access/rmgrdesc/xactdesc.c          | 11 ++---
src/backend/access/spgist/spgscan.c             |  3 +-
src/backend/access/transam/xact.c               | 12 ++---
src/backend/catalog/heap.c                      |  3 +-
src/backend/commands/event_trigger.c            |  6 +--
src/backend/commands/tablecmds.c                |  3 +-
src/backend/executor/execExprInterp.c           |  6 +--
src/backend/executor/nodeAgg.c                  |  6 +--
src/backend/libpq/auth.c                        |  6 +--
src/backend/optimizer/path/joinpath.c           |  3 +-
src/backend/optimizer/plan/createplan.c         |  6 +--
src/backend/postmaster/pgstat.c                 | 12 ++---
src/backend/replication/logical/logicalfuncs.c  |  3 +-
src/backend/replication/logical/reorderbuffer.c |  3 +-
src/backend/tcop/utility.c                      |  3 +-
src/backend/tsearch/dict_thesaurus.c            |  8 +---
src/backend/tsearch/to_tsany.c                  |  3 +-
src/backend/tsearch/ts_parse.c                  | 12 ++---
src/backend/utils/adt/formatting.c              |  3 +-
src/backend/utils/adt/pgstatfuncs.c             |  6 +--
src/backend/utils/adt/rangetypes_spgist.c       |  3 +-
src/backend/utils/adt/rangetypes_typanalyze.c   |  9 ++--
src/backend/utils/adt/ruleutils.c               |  3 +-
src/backend/utils/adt/timestamp.c               |  6 +--
src/backend/utils/adt/tsgistidx.c               | 12 ++---
src/backend/utils/adt/tsquery_op.c              | 11 ++---
src/backend/utils/adt/tsvector_op.c             | 22 ++++-----
src/backend/utils/misc/pg_controldata.c         |  3 +-
src/bin/pg_upgrade/tablespace.c                 |  7 ++-
src/bin/psql/help.c                             |  6 +--
src/interfaces/libpq/fe-connect.c               | 45 +++++++++---------
src/interfaces/libpq/fe-misc.c                  |  3 +-
src/interfaces/libpq/fe-protocol2.c             |  8 +---
src/interfaces/libpq/fe-protocol3.c             |  6 +--
src/interfaces/libpq/fe-secure-openssl.c        | 12 ++---
src/interfaces/libpq/fe-secure.c                |  6 +--
src/interfaces/libpq/win32.c                    |  9 ++--
src/pl/plperl/plperl.c                          |  7 +--
src/pl/plpython/plpy_elog.c                     |  6 +--
src/pl/tcl/pltcl.c                              |  8 ++--
src/port/gettimeofday.c                         |  3 +-
78 files changed, 342 insertions(+), 538 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Remove excess parens in ereport() calls
Next
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Add reusable routine for making arrays unique.