pgsql: Add an ugly workaround for a bug in some recent libedit versions - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Add an ugly workaround for a bug in some recent libedit versions
Date
Msg-id E1inPbx-00043o-0D@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add an ugly workaround for a bug in some recent libedit versions.

Debian unstable is shipping a broken version of libedit: it de-escapes
words before passing them to the application's tab completion function,
preventing us from recognizing backslash commands.  Fortunately,
we have enough information available to dig the original text out of
rl_line_buffer, so ignore the string argument and do that.

I view this as a temporary workaround to get the affected buildfarm
members back to green in the wake of 7c015045b.  I hope we can get
rid of it once somebody fixes Debian's libedit; hence, no back-patch,
at least for now.

Discussion: https://postgr.es/m/20200103110128.GA28967@msg.df7cb.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ddd87d564508bb1c80aac0a4439cfe74a3c203a9

Modified Files
--------------
src/bin/psql/tab-complete.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Next
From: Tom Lane
Date:
Subject: pgsql: Further fixes for tab-completion TAP tests.