pgsql: Fix failures with TAP tests of pg_ctl on Windows - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Fix failures with TAP tests of pg_ctl on Windows
Date
Msg-id E1ibzOJ-0002Wn-VZ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix failures with TAP tests of pg_ctl on Windows

On Windows, all the hosts spawned by the TAP tests bind to 127.0.0.1.
Hence, if there is a port conflict, starting a cluster would immediately
fail.  One of the test scripts of pg_ctl initializes a node without
PostgresNode.pm, using the default port 5432.  This could cause
unexpected startup failures in the tests if an independent server was up
and running on the same host (the reverse is also possible, though more
unlikely).  Fix this issue by assigning properly a free port to the node
configured, in the same range used as for the other nodes part of the
tests.

Author: Michael Paquier
Reviewed-by: Andrew Dunstan
Discussion: https://postgr.es/m/20191202031444.GC1696@paquier.xyz
Backpatch-through: 11

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e5532f194c18e6c12c3aa9cb07291973dc8adb39

Modified Files
--------------
src/bin/pg_ctl/t/001_start_stop.pl | 2 ++
1 file changed, 2 insertions(+)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix EXPLAIN's column alias output for mismatched child tables.
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix failures with TAP tests of pg_ctl on Windows