pgsql: Fix traversing to the deleted GIN page via downlink - Mailing list pgsql-committers

From Alexander Korotkov
Subject pgsql: Fix traversing to the deleted GIN page via downlink
Date
Msg-id E1iXAqj-0001if-Bj@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix traversing to the deleted GIN page via downlink

Current GIN code appears to don't handle traversing to the deleted page via
downlink.  This commit fixes that by stepping right from the delete page like
we do in nbtree.

This commit also fixes setting 'deleted' flag to the GIN pages.  Now other page
flags are not erased once page is deleted.  That helps to keep our assertions
true if we arrive deleted page via downlink.

Discussion: https://postgr.es/m/CAPpHfdvMvsw-NcE5bRS7R1BbvA4BxoDnVVjkXC5W0Czvy9LVrg%40mail.gmail.com
Author: Alexander Korotkov
Reviewed-by: Peter Geoghegan
Backpatch-through: 9.4

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1414821e1688c86266c5ecaad378086785152332

Modified Files
--------------
src/backend/access/gin/ginbtree.c    | 7 -------
src/backend/access/gin/gindatapage.c | 3 +++
src/backend/access/gin/ginvacuum.c   | 2 +-
src/backend/access/gin/ginxlog.c     | 2 +-
4 files changed, 5 insertions(+), 9 deletions(-)


pgsql-committers by date:

Previous
From: Alexander Korotkov
Date:
Subject: pgsql: Fix traversing to the deleted GIN page via downlink
Next
From: Alexander Korotkov
Date:
Subject: pgsql: Fix page modification outside of critical section in GIN