pgsql: Always call ExecShutdownNode() if appropriate. - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Always call ExecShutdownNode() if appropriate.
Date
Msg-id E1iVjBO-0001Yq-46@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Always call ExecShutdownNode() if appropriate.

Call ExecShutdownNode() after ExecutePlan()'s loop, rather than at each
break.  We had forgotten to do that in one case.  The omission caused
intermittent "temporary file leak" warnings from multi-batch parallel
hash joins with a LIMIT clause.

Back-patch to 11.  Though the problem exists in theory in earlier
parallel query releases, nothing really depended on it.

Author: Kyotaro Horiguchi
Reviewed-by: Thomas Munro, Amit Kapila
Discussion: https://postgr.es/m/20191111.212418.2222262873417235945.horikyota.ntt%40gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bc049d0d460aead528ace909a3477bc701ab2e9a

Modified Files
--------------
src/backend/executor/execMain.c | 23 +++++++----------------
1 file changed, 7 insertions(+), 16 deletions(-)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Always call ExecShutdownNode() if appropriate.
Next
From: Tomas Vondra
Date:
Subject: pgsql: Skip system attributes when applying mvdistinct stats