pgsql: Fix assertion failure when running pgbench -s. - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: Fix assertion failure when running pgbench -s.
Date
Msg-id E1iScKX-00032i-KG@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix assertion failure when running pgbench -s.

If there is the WAL page that the continuation WAL record just fits within
(i.e., the continuation record ends just at the end of the page) and
the LSN in such page is specified with -s option, previously pg_waldump
caused an assertion failure. The cause of this assertion failure was that
XLogFindNextRecord() that pg_waldump -s calls mistakenly handled
such special WAL page.

This commit changes XLogFindNextRecord() so that it can handle
such WAL page correctly.

Back-patch to all supported versions.

Author: Andrey Lepikhov
Reviewed-by: Fujii Masao, Michael Paquier
Discussion: https://postgr.es/m/99303554-5dd5-06e6-f943-b3005ccd6edd@postgrespro.ru

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1accf997482122d69493f942a6aa89cf34b3fd75

Modified Files
--------------
src/backend/access/transam/xlogreader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Fujii Masao
Date:
Subject: pgsql: Fix assertion failure when running pgbench -s.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Fix nested error handling in PG_FINALLY