pgsql: pg_waldump: Fix --bkp-details to not issue spurious newlines for - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: pg_waldump: Fix --bkp-details to not issue spurious newlines for
Date
Msg-id E1iPh0c-0001T8-2R@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_waldump: Fix --bkp-details to not issue spurious newlines for FPWs.

The additional newline seems to have accidentally been introduced in
2c03216d831, in 9.5. The newline is only issued when an FPW is
present for the block reference.

While there could be an argument that removing the newlines in the
back branches could cause a problem for somebody parsing the
pg_waldump output, the likelihood of that seems small enough. It seems
at least equally likely that the randomness of when newlines are
issued causes problems.

Author: Andres Freund
Discussion: https://postgr.es/m/20191029233341.4gnyau7e5v2lh5sc@alap3.anarazel.de
Backpatch: 9.5, like 2c03216d831.

Branch
------
REL9_5_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/39ff656a415118cdd8231ee524aeed67796062a4

Modified Files
--------------
src/bin/pg_xlogdump/pg_xlogdump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: pg_waldump: Fix --bkp-details to not issue spurious newlines for
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Update code comments about peer authenticaton