pgsql: Make the order of the header file includes consistent in contrib - Mailing list pgsql-committers

Make the order of the header file includes consistent in contrib modules.

The basic rule we follow here is to always first include 'postgres.h' or
'postgres_fe.h' whichever is applicable, then system header includes and
then Postgres header includes.  In this, we also follow that all the
Postgres header includes are in order based on their ASCII value.  We
generally follow these rules, but the code has deviated in many places.
This commit makes it consistent just for contrib modules.  The later
commits will enforce similar rules in other parts of code.

Author: Vignesh C
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/CALDaNm2Sznv8RR6Ex-iJO6xAdsxgWhCoETkaYX=+9DW3q0QCfA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7e735035f208418f31b91846ae3e8a381edb3af3

Modified Files
--------------
contrib/bloom/blcost.c                    |  3 +--
contrib/bloom/blinsert.c                  |  3 +--
contrib/bloom/blscan.c                    |  5 ++---
contrib/bloom/blutils.c                   | 10 ++++------
contrib/bloom/blvalidate.c                |  3 +--
contrib/btree_gin/btree_gin.c             |  2 +-
contrib/btree_gist/btree_enum.c           |  4 ++--
contrib/btree_gist/btree_inet.c           |  2 +-
contrib/btree_gist/btree_numeric.c        |  3 +--
contrib/btree_gist/btree_utils_var.c      |  5 ++---
contrib/cube/cube.c                       |  3 +--
contrib/dblink/dblink.c                   |  3 +--
contrib/hstore/hstore_gist.c              |  3 +--
contrib/hstore/hstore_io.c                |  3 +--
contrib/hstore/hstore_op.c                |  3 +--
contrib/hstore_plpython/hstore_plpython.c |  4 ++--
contrib/intarray/_int_bool.c              |  3 +--
contrib/intarray/_int_gin.c               |  3 +--
contrib/intarray/_int_gist.c              |  3 +--
contrib/intarray/_int_op.c                |  1 -
contrib/intarray/_int_selfuncs.c          |  6 +++---
contrib/intarray/_int_tool.c              |  4 +---
contrib/intarray/_intbig_gist.c           |  3 +--
contrib/isn/isn.c                         |  7 +++----
contrib/jsonb_plperl/jsonb_plperl.c       |  2 +-
contrib/jsonb_plpython/jsonb_plpython.c   |  4 ++--
contrib/ltree/_ltree_gist.c               |  4 +---
contrib/ltree/crc32.c                     |  2 +-
contrib/ltree/lquery_op.c                 |  2 +-
contrib/ltree/ltree_io.c                  |  2 +-
contrib/ltree/ltree_op.c                  |  2 +-
contrib/ltree_plpython/ltree_plpython.c   |  2 +-
contrib/oid2name/oid2name.c               |  4 +---
contrib/pageinspect/brinfuncs.c           |  8 +++-----
contrib/pageinspect/btreefuncs.c          |  4 +---
contrib/pageinspect/fsmfuncs.c            |  3 +--
contrib/pageinspect/ginfuncs.c            |  3 +--
contrib/pageinspect/hashfuncs.c           |  5 ++---
contrib/pageinspect/heapfuncs.c           |  5 ++---
contrib/pageinspect/rawpage.c             |  3 +--
contrib/passwordcheck/passwordcheck.c     |  2 +-
contrib/pg_standby/pg_standby.c           |  3 +--
contrib/pg_trgm/trgm_gin.c                |  4 +---
contrib/pg_trgm/trgm_gist.c               |  4 +---
contrib/pg_trgm/trgm_op.c                 |  3 +--
contrib/pg_trgm/trgm_regexp.c             |  4 +---
contrib/pgcrypto/crypt-md5.c              |  2 +-
contrib/pgcrypto/internal.c               |  6 +++---
contrib/pgcrypto/mbuf.c                   |  2 +-
contrib/pgcrypto/openssl.c                |  3 +--
contrib/pgcrypto/pgcrypto.c               |  7 +++----
contrib/pgcrypto/pgp-armor.c              |  2 +-
contrib/pgcrypto/pgp-cfb.c                |  2 +-
contrib/pgcrypto/pgp-compress.c           |  3 +--
contrib/pgcrypto/pgp-decrypt.c            |  2 +-
contrib/pgcrypto/pgp-encrypt.c            |  3 +--
contrib/pgcrypto/pgp-info.c               |  2 +-
contrib/pgcrypto/pgp-mpi-internal.c       |  3 +--
contrib/pgcrypto/pgp-mpi-openssl.c        |  2 +-
contrib/pgcrypto/pgp-mpi.c                |  2 +-
contrib/pgcrypto/pgp-pgsql.c              | 11 +++++------
contrib/pgcrypto/pgp-pubdec.c             |  2 +-
contrib/pgcrypto/pgp-pubenc.c             |  2 +-
contrib/pgcrypto/pgp-pubkey.c             |  2 +-
contrib/pgcrypto/pgp-s2k.c                |  3 +--
contrib/pgcrypto/pgp.c                    |  2 +-
contrib/pgcrypto/px-crypt.c               |  3 +--
contrib/pgstattuple/pgstatapprox.c        |  6 +++---
contrib/postgres_fdw/connection.c         |  4 +---
contrib/postgres_fdw/deparse.c            |  4 +---
contrib/postgres_fdw/option.c             |  4 +---
contrib/postgres_fdw/postgres_fdw.c       |  3 +--
contrib/postgres_fdw/shippable.c          |  4 +---
contrib/sepgsql/database.c                |  4 ++--
contrib/sepgsql/dml.c                     |  5 ++---
contrib/sepgsql/hooks.c                   |  3 +--
contrib/sepgsql/label.c                   |  5 ++---
contrib/sepgsql/proc.c                    |  3 +--
contrib/sepgsql/relation.c                |  7 +++----
contrib/sepgsql/schema.c                  |  3 +--
contrib/sepgsql/uavc.c                    |  3 +--
contrib/spi/moddatetime.c                 |  2 +-
contrib/tablefunc/tablefunc.c             |  3 +--
contrib/tcn/tcn.c                         |  2 +-
contrib/vacuumlo/vacuumlo.c               |  3 +--
85 files changed, 115 insertions(+), 183 deletions(-)