pgsql: Fix parsing of integer values for connection parameters in libpq - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Fix parsing of integer values for connection parameters in libpq
Date
Msg-id E1iMNH3-0008Tp-T0@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Fix parsing of integer values for connection parameters inlibpq  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-committers
Fix parsing of integer values for connection parameters in libpq

Commit e7a2217 has introduced stricter checks for integer values in
connection parameters for libpq.  However this failed to correctly check
after trailing whitespaces, while leading whitespaces were discarded per
the use of strtol(3).  This fixes and refactors the parsing logic to
handle both cases consistently.  Note that trying to restrict the use of
trailing whitespaces can easily break connection strings like in ECPG
regression tests (these have allowed me to catch the parsing bug with
connect_timeout).

Author: Michael Paquier
Reviewed-by: Lars Kanis
Discussion: https://postgr.es/m/a9b4cbd7-4ecb-06b2-ebd7-1739bbff3217@greiz-reinsdorf.de
Backpatch-through: 12

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2b0f959b5119cb2bb1d135ac04a8c5272bbcab03

Modified Files
--------------
src/interfaces/libpq/fe-connect.c | 29 +++++++++++++++++++++++------
1 file changed, 23 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Clean up MinGW def file generation
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix error reporting of connect_timeout in libpq for value parsin