Fix RelationIdGetRelation calls that weren't bothering with error checks.
Some of these are quite old, but that doesn't make them not bugs.
We'd rather report a failure via elog than SIGSEGV.
While at it, uniformly spell the error check as !RelationIsValid(rel)
rather than a bare rel == NULL test. The machine code is the same
but it seems better to be consistent.
Coverity complained about this today, not sure why, because the
mistake is in fact old.
Branch
------
REL9_5_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/87ee1587c94d04e8c91d9346cd632369bede586c
Modified Files
--------------
src/backend/access/heap/heapam.c | 4 ++++
src/backend/replication/logical/reorderbuffer.c | 6 +++++-
2 files changed, 9 insertions(+), 1 deletion(-)
