pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator - Mailing list pgsql-committers

From Alexander Korotkov
Subject pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator
Date
Msg-id E1i72u0-0001Sk-E5@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix handling Inf and Nan values in GiST pairing heap comparator

Previously plain float comparison was used in GiST pairing heap.  Such
comparison doesn't provide proper ordering for value sets containing Inf and Nan
values.  This commit fixes that by usage of float8_cmp_internal().  Note, there
is remaining problem with NULL distances, which are represented as Inf in
pairing heap.  It would be fixes in subsequent commit.

Backpatch to all supported versions.

Reported-by: Andrey Borodin
Discussion: https://postgr.es/m/CAPpHfdsNvNdA0DBS%2BwMpFrgwT6C3-q50sFVGLSiuWnV3FqOJuQ%40mail.gmail.com
Author: Alexander Korotkov
Reviewed-by: Heikki Linnakangas
Backpatch-through: 9.4

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/111fb7e42e335bbe104939418ec44c903d3b2329

Modified Files
--------------
src/backend/access/gist/gistscan.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Alexander Korotkov
Date:
Subject: pgsql: Fix handling of NULL distances in KNN-GiST
Next
From: Tom Lane
Date:
Subject: pgsql: Fix RelationIdGetRelation calls that weren't bothering witherro