pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator - Mailing list pgsql-committers

From Alexander Korotkov
Subject pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator
Date
Msg-id E1i72tO-0001Oq-Lh@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix handling Inf and Nan values in GiST pairing heap comparator

Previously plain float comparison was used in GiST pairing heap.  Such
comparison doesn't provide proper ordering for value sets containing Inf and Nan
values.  This commit fixes that by usage of float8_cmp_internal().  Note, there
is remaining problem with NULL distances, which are represented as Inf in
pairing heap.  It would be fixes in subsequent commit.

Backpatch to all supported versions.

Reported-by: Andrey Borodin
Discussion: https://postgr.es/m/CAPpHfdsNvNdA0DBS%2BwMpFrgwT6C3-q50sFVGLSiuWnV3FqOJuQ%40mail.gmail.com
Author: Alexander Korotkov
Reviewed-by: Heikki Linnakangas
Backpatch-through: 9.4

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e5d8f3596100da0d38a38513c69e803b7fe7041a

Modified Files
--------------
src/backend/access/gist/gistscan.c         |  7 +++++--
src/test/regress/expected/create_index.out | 10 +++++-----
2 files changed, 10 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: configure: Update python search order
Next
From: Alexander Korotkov
Date:
Subject: pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator